PB-2064: fix footer, topics, menuTray cypress tests #1521
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-pb-2064-footer-cypress
|
| Run status |
|
| Run duration | 08m 57s |
| Commit |
|
| Committer | Felix Sommer |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
36
|
Flaky
|
0
|
Pending
|
19
|
Skipped
|
0
|
Passing
|
129
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
drawing.cy.ts • 1 failed test • e2e/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
|
layers.cy.ts • 1 failed test • e2e/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
|
legacyParamImport.cy.ts • 1 failed test • e2e/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
|
timeSlider.cy.ts • 1 failed test • e2e/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
|
3d/layers.cy.ts • 1 failed test • e2e/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
|
The first 5 failed specs are shown, see all 22 specs in Cypress Cloud.
sommerfe
force-pushed
the
fix-pb-2064-footer-cypress
branch
from
a61bc52 to
6392813
Compare
sommerfe
changed the title
pakb
reviewed
Dec 9, 2025
packages/viewer/src/App.vue
Outdated
| layersStore.loadLayersConfig( | ||
| { | ||
| changeLayersOnTopicChange: !window.location.hash.includes('layers='), | ||
| changeLayersOnTopicChange: !(window.location.hash.includes('layers=') || window.location.hash.includes('bgLayer=')), |
Contributor
There was a problem hiding this comment.
This does not really make sense to me, as it translate to:
Change the layers on the map if
- There is no layer defined
- OR if there is a background layer defined
It should be:
- There is no layer defined
- AND there is no bgLayer defined
No?
Contributor
Author
There was a problem hiding this comment.
yes it is exactly as you say, note that there is a parentheses in front of the !
so it is !(A || B) === !A && !B
i can rewrite it to make it more clear
sommerfe
force-pushed
the
fix-pb-2064-footer-cypress
branch
from
f47ca57 to
ace5db9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link