PB-2064: Fix header test #1523
Open
PB-2064: Fix header test #1523
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismailsunni
force-pushed
the
fix-pb-2064-header-test
branch
from
6f9ec35 to
cb87015
Compare
web-mapviewer
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-pb-2064-header-test
|
| Run status |
|
| Run duration | 10m 31s |
| Commit |
|
| Committer | Ismail Sunni |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
60
|
Flaky
|
0
|
Pending
|
19
|
Skipped
|
0
|
Passing
|
146
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
drawing.cy.ts • 1 failed test • e2e/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
|
timeSlider.cy.ts • 1 failed test • e2e/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
|
print.cy.ts • 1 failed test • e2e/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
|
legacyParamImport.cy.ts • 1 failed test • e2e/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
|
menuTray.cy.ts • 1 failed test • e2e/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
|
The first 5 failed specs are shown, see all 24 specs in Cypress Cloud.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a header test by correcting the app reset functionality to properly use hash-based routing. The reset function previously attempted to change the full URL with window.location.href, which was incompatible with the app's hash-based routing architecture. The fix updates it to use window.location.hash followed by a forced reload.
- Changed from setting
window.location.hrefto settingwindow.location.hashand callingwindow.location.reload() - Added explanatory comments about hash-based URL setting and forced reload behavior
- Ensures proper page reload for Cypress tests that wait for API calls
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ismailsunni
force-pushed
the
fix-pb-2064-header-test
branch
from
cb87015 to
2f6614c
Compare
ismailsunni
force-pushed
the
fix-pb-2064-header-test
branch
from
2f6614c to
949f4fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link