PB-2064: Fix crosshair test

[ismailsunni]

Test link

[Copilot]

Pull request overview

This PR fixes a crosshair test by correcting the enum validation logic and adding support for crosshair URL parameters without explicit coordinates.

Key Changes:

• Fixed enum validation in setCrossHair action to check enum values instead of enum keys
• Added handling for crosshair URL parameters that specify only the type (without coordinates), using map center as the default position

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
packages/viewer/src/store/modules/position/actions/setCrossHair.ts	Fixed the crosshair validation check from crossHair in CrossHairs (which checked for enum keys like 'Point', 'Cross') to Object.values(CrossHairs).includes(crossHair) (which correctly checks for enum values like 'point', 'cross')
packages/viewer/src/store/plugins/storeSync/params/crosshair.param.ts	Added else-if branch to handle URL parameters where only the crosshair type is provided without coordinates, ensuring the crosshair is placed at the map center as expected by the test

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cypress]

web-mapviewer    Run #6134

Run Properties:   Errored #6134  •  4716db2b55: PB-2064: Fix failed to parse crosshair.

Project	web-mapviewer
Branch Review	fix-pb-2064-crosshair-test
Run status	Errored #6134
Run duration	12m 36s
Commit	4716db2b55: PB-2064: Fix failed to parse crosshair.
Committer	Ismail Sunni
View all properties for this run ↗︎

---

Test results
Failures	54
Flaky	0
Pending	19
Skipped	7
Passing	145
View all changes introduced in this branch ↗︎

---

Tests for review

  drawing.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test		Artifacts
An uncaught error was detected outside of a test		Test Replay Screenshots

  timeSlider.cy.ts • 3 failed tests • e2e/chrome/mobile

View Output

Test		Artifacts
Cypress tests covering the time slider, its functionalities and its URL parameter > checking the time slider behavior, both on startup and during use > checks that the time slider is functional and behave correctly part 1		Test Replay Screenshots
Cypress tests covering the time slider, its functionalities and its URL parameter > checking the time slider behavior, both on startup and during use > checks that the time slider is functional and behave correctly with the timeSlider param at startup		Test Replay Screenshots
Cypress tests covering the time slider, its functionalities and its URL parameter > checking the time slider behavior, both on startup and during use > behaves correctly when years are being entered in the input		Test Replay Screenshots

  print.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test		Artifacts
An uncaught error was detected outside of a test		Test Replay Screenshots

  legacyParamImport.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test		Artifacts
An uncaught error was detected outside of a test		Test Replay Screenshots

  menuTray.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test		Artifacts
An uncaught error was detected outside of a test		Test Replay Screenshots

The first 5 failed specs are shown, see all 23 specs in Cypress Cloud.