Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve C++ interface to geoarrow-c #108

Merged
merged 25 commits into from
Jan 1, 2025

Conversation

paleolimbot
Copy link
Contributor

@paleolimbot paleolimbot commented Dec 30, 2024

This PR is a general improvement on all things in geoarrow.hpp. Some notable improvements:

  • The VectorType was renamed to GeometryDataType. This mirrors the naming of GeometryExtensionType in geoarrow.pyarrow, which was updated from VectorType several months ago.
  • C++ functions now throw exceptions. Before, errors were propagated using a custom system that was easy to mess up. C++ users that don't want this can use the C interface.
  • Moved the ToString for a GeometryDataType to C++ from Cython
  • The Python bindings, which are mostly a wrapper around the C++ geometry data type, were updated
  • An ArrayReader and ArrayWriter were added with C++y templated buffer setters
  • Improved test coverage on geoarrow.hpp

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 84.23423% with 35 lines in your changes missing coverage. Please review.

Project coverage is 91.61%. Comparing base (7d9dc2f) to head (9ef367e).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/geoarrow/geoarrow_type_inline.h 32.25% 21 Missing ⚠️
src/geoarrow/geoarrow.hpp 90.42% 9 Missing ⚠️
src/geoarrow/geoarrow_arrow.hpp 92.15% 4 Missing ⚠️
python/geoarrow-c/src/geoarrow/c/_lib.pyx 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   91.28%   91.61%   +0.32%     
==========================================
  Files          24       24              
  Lines        3843     4089     +246     
==========================================
+ Hits         3508     3746     +238     
- Misses        335      343       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paleolimbot paleolimbot marked this pull request as ready for review January 1, 2025 04:32
@paleolimbot paleolimbot merged commit 5841fe4 into geoarrow:main Jan 1, 2025
9 checks passed
@paleolimbot paleolimbot deleted the geoarrow-hpp branch January 1, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant