refactor: Separate out visitor-based native array writer from buffer-based writer for native arrays #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the consistency of the C API by adding the
GeoArrowNativeWriterto match theGeoArrowWKTWriterandGeoArrowWKBWriter. Before, theGeoArrowBuilderserved the purpose of both building by buffer and building by visitor, which was slightly confusing since it could be used to build WKB and WKT arrays too (except when using the visitor).This hopefully makes it more clear that the
GeoArrowArrayWriterandGeoArrowArrayReaderare the things you want if you are reading arbitrary input/generating arbitrary output.