Proofreading c5 #1128
Merged
Proofreading c5 #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robinlovelace
approved these changes
Sep 28, 2024
There was a problem hiding this comment.
Some definite fixes in there. Will merge.
Some questions to revisit though cc @Nowosad see comments and let's do a last sweep with global search/replace for consistency after all chapters reviewed individually.
| @@ -20,7 +20,7 @@ library(spDataLarge) | |||
|
|
|||
| So far the book has explained the structure of geographic datasets (Chapter \@ref(spatial-class)), and how to manipulate them based on their non-geographic attributes (Chapter \@ref(attr)) and spatial relations (Chapter \@ref(spatial-operations)). | |||
| This chapter focuses on manipulating the geographic elements of spatial objects, for example by creating buffers, simplifying and converting vector geometries, and aggregating and resampling raster data. | |||
| After reading it --- and attempting the exercises at the end --- you should understand and have control over the geometry column in `sf` objects and the extent and geographic location of pixels represented in rasters in relation to other geographic objects. | |||
| After reading it --- and attempting the Exercises at the end --- you should understand and have control over the geometry column in `sf` objects and the extent and geographic location of pixels represented in rasters in relation to other geographic objects. | |||
There was a problem hiding this comment.
Really? No objections, the capitalisation highlights them, but not sure it's necessary. No biggy either way, we should check to see if this applied consistently.
| @@ -51,7 +51,7 @@ Another reason for simplifying objects is to reduce the amount of memory, disk s | |||
| it may be wise to simplify complex geometries before publishing them as interactive maps. | |||
| The **sf** package provides `st_simplify()`, which uses the Douglas-Peucker algorithm to reduce the vertex count. | |||
| `st_simplify()` uses the `dTolerance` to control the level of generalization in map units [see @douglas_algorithms_1973 for details]. | |||
| Figure \@ref(fig:seine-simp) illustrates simplification of a `LINESTRING` geometry representing the river Seine and tributaries. | |||
| Figure \@ref(fig:seine-simp) illustrates simplification of a `LINESTRING` geometry representing the River Seine and tributaries. | |||
| @@ -89,8 +89,8 @@ This means the 'topology' is lost, resulting in overlapping and 'holey' areal un | |||
| By default it uses the Visvalingam algorithm, which overcomes some limitations of the Douglas-Peucker algorithm [@visvalingam_line_1993]. | |||
| <!-- https://bost.ocks.org/mike/simplify/ --> | |||
| The following code chunk uses this function to simplify `us_states`. | |||
| The result has only 1% of the vertices of the input (set using the argument `keep`) but its number of objects remains intact because we set `keep_shapes = TRUE`:^[ | |||
| Simplification of multipolygon objects can remove small internal polygons, even if the `keep_shapes` argument is set to TRUE. To prevent this, you need to set `explode = TRUE`. This option converts all mutlipolygons into separate polygons before its simplification. | |||
| The result has only 1% of the vertices of the input (set using the argument `keep`), but its number of objects remains intact because we set `keep_shapes = TRUE`:^[ | |||
| @@ -300,15 +300,15 @@ rotation = function(a){ | |||
| } | |||
| ``` | |||
|
|
|||
| The `rotation` function accepts one argument `a` - a rotation angle in degrees. | |||
| The `rotation` function accepts one argument `a` --- a rotation angle in degrees. | |||
| plot(b, border = "grey") | ||
| plot(x_and_y, col = "lightgrey", border = "grey", add = TRUE) # intersecting area | ||
| plot(b, border = "gray") | ||
| plot(x_and_y, col = "lightgray", border = "gray", add = TRUE) # intersecting area |
There was a problem hiding this comment.
I thought there was an issue but testing suggests it's OK:
plot(1:9, col = "gray")
Created on 2024-09-28 with reprex v2.1.0
There was a problem hiding this comment.
Do we now use "gray" throughout?
| resolution = c("(30.85, 30.85)", "(154.25, 154.25)"), | ||
| dimensions = c("117 x 117", "24 x 24"), | ||
| extent = c("794599.1, 798208.6, 8931775, 8935384", "794599.1, 798301.1, 8931682, 8935384") | ||
| Object = c("dem", "dem_agg"), |
| @@ -118,8 +118,8 @@ arrange(us_states_bor, -borders) | |||
| ``` | |||
|
|
|||
| E7. Read the srtm.tif file into R (`srtm = rast(system.file("raster/srtm.tif", package = "spDataLarge"))`). | |||
| This raster has a resolution of 0.00083 by 0.00083 degrees. | |||
| Change its resolution to 0.01 by 0.01 degrees using all of the method available in the **terra** package. | |||
| This raster has a resolution of 0.00083 * 0.00083 degrees. | |||
There was a problem hiding this comment.
Really? cc @Nowosad
github-actions bot
pushed a commit
that referenced
this pull request
Sep 28, 2024
* add first set of reviewer suggestions * add second set of changes --------- Co-authored-by: jannes <jannes@cynkra.com> c8635ca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.