Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs proofing #1132

Merged
merged 14 commits into from
Sep 30, 2024
Merged

Refs proofing #1132

merged 14 commits into from
Sep 30, 2024

Conversation

Robinlovelace
Copy link
Collaborator

No description provided.

@Robinlovelace Robinlovelace mentioned this pull request Sep 30, 2024
13-transport.Rmd Outdated Show resolved Hide resolved
@Robinlovelace
Copy link
Collaborator Author

@Nowosad and @jannes-m please can you review this so we can get it merged? Plan with refs is to remove pesky package names.

@Robinlovelace
Copy link
Collaborator Author

But we can finish the references in separate PR, this is mostly focuss on transport chapter.

@Nowosad
Copy link
Member

Nowosad commented Sep 30, 2024

I made one tiny change, but otherwise it is good to go 👍🏻

@Robinlovelace Robinlovelace merged commit 0b4734a into main Sep 30, 2024
2 of 3 checks passed
@Robinlovelace Robinlovelace deleted the refs-proofing branch September 30, 2024 14:28
@Robinlovelace
Copy link
Collaborator Author

🚀

@Robinlovelace
Copy link
Collaborator Author

Just the refs now. Do you want to have a bash at that @Nowosad, picking up on my start? It seems R package refs are an issue, I don't mind removing them.

@Robinlovelace
Copy link
Collaborator Author

And a few more chapters @jannes-m is signed up for in #1115

github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
@Nowosad
Copy link
Member

Nowosad commented Sep 30, 2024

@Robinlovelace I think that we should keep the packages references (i.e., to show good citing practices to other people); I made a simple PR at #1133, but more importantly, I edited many references at Zotero's geocompr library. Please export them and do a double check.

@Robinlovelace
Copy link
Collaborator Author

Good to see @Nowosad. I will put in a PR to that branch so you can review the changes made by the export.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants