Merge pull request #5935 from tjhei/clang-tidy-fixes2

clang tidy rule fix and a fix
geodynamics · Jun 24, 2024 · e282a89 · e282a89
2 parents b302651 + e278ad3
commit e282a89
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -58,7 +58,7 @@ Checks: >
   use-emplace,
   mpi-*,
   performance-*,
-  -performance-avoid-endl
+  -performance-avoid-endl,
   -performance-enum-size,
   -performance-inefficient-string-concatenation,
-  -performance-no-automatic-move,
+  -performance-no-automatic-move
diff --git a/source/postprocess/visualization.cc b/source/postprocess/visualization.cc
@@ -585,7 +585,7 @@ namespace aspect
                     output_history.background_thread.join();
                   // ...then continue with writing our own data.
                   output_history.background_thread
-                    = std::thread([ my_filename = std::move(filename),
+                    = std::thread([ my_filename = filename, // filename is const, so we can not move from it
                                     my_temporary_output_location = temporary_output_location,
                                     my_file_contents = std::move(file_contents)]()
                   {