Test spec edits #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrickbeining
commented
Aug 12, 2017
test/user.test.js
Outdated
| }); | ||
| }, function ( err ) { | ||
| expect( err ).to.be.an.instanceOf( Error ); | ||
| expect(err.errors[0].type).to.contain('notNull Violation'); |
There was a problem hiding this comment.
alternatively:
expect(err.message).to.contain('Validation Error');
seems to work too
…as passing when it should have failed.
|
Also found that the spec on line 52 was passing my code when it should have been failing. I've added an edit to that as well so that it throws an error if it passes when it should've failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original spec on line 48 was expecting the err.message to be something that it wasn't, and therefore causing the spec to fail even though my code was correct. I've changed the spec so that it expects the notNull error.message I was getting.
Not sure if this has been an issue for anyone else, but it might be a good idea to notify everyone else so they don't waste time trying to figure out why they can't get it to pass.