Add warning when 'unmock' called without arguments

geofffranks · Jun 12, 2020 · 4dacd82 · 4dacd82
1 parent b20dc7c
commit 4dacd82
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lib/Test/MockModule.pm b/lib/Test/MockModule.pm
@@ -157,6 +157,7 @@ sub original {
 sub unmock {
 	my $self = shift;
 
+	carp 'Nothing to unmock' unless @_;
 	for my $name (@_) {
 		croak "Invalid subroutine name: $name" unless _valid_subname($name);
 

diff --git a/t/mockmodule.t b/t/mockmodule.t
@@ -103,6 +103,9 @@ like($@, qr/Invalid package name/, ' ... croaks if package is undefined');
 	$mcgi->unmock('Vars');
 	like($warn, qr/ was not mocked/, "... warns if a subroutine isn't mocked");
 
+	$mcgi->unmock();
+	like($warn, qr/Nothing to unmock/, '... warns if no arguments passed to unmock');
+
 	$mcgi->unmock('param');
 	is(\&{"ExampleModule::param"}, $orig_param, '... restores the original subroutine');