Merge pull request #44 from deathiop/dev/abarreau/in_equality

fix: ValueFilter.IsEquality is false for `in` filters
geoffreybauduin · Nov 3, 2020 · a9e7f74 · a9e7f74
2 parents 4f01be4 + 6763b6c
commit a9e7f74
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/yaormfilter/tools_test.go b/yaormfilter/tools_test.go
@@ -23,6 +23,9 @@ func TestEquality(t *testing.T) {
 
 	f = yaormfilter.NotEquals("bdef")
 	assert.False(t, f.IsEquality())
+
+	f = yaormfilter.In([]string{"abc", "bdef"})
+	assert.False(t, f.IsEquality())
 }
 
 func TestNotEquals(t *testing.T) {

diff --git a/yaormfilter/valuefilter.go b/yaormfilter/valuefilter.go
@@ -70,7 +70,9 @@ func (f *valuefilterimpl) like(e interface{}) *valuefilterimpl {
 }
 
 func (f *valuefilterimpl) in(e []interface{}) *valuefilterimpl {
-	return f.equals(e)
+	return f.raw(func(field string) interface{} {
+		return squirrel.Eq{field: e}
+	})
 }
 
 func (f *valuefilterimpl) notIn(e []interface{}) *valuefilterimpl {