Module 5 exercises C, D, & E #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadly we need to have line numbers enabled
mfisher87
force-pushed
the
module-5-continued
branch
from
4fe3432 to
044e245
Compare
mfisher87
force-pushed
the
module-5-continued
branch
from
b972133 to
cca831b
Compare
Maybe this will warn people against jumping in this rabbit hole ;)
mfisher87
changed the title
Merged
rowanc1
reviewed
Nov 27, 2025
rowanc1
left a comment
rowanc1
left a comment
There was a problem hiding this comment.
A few comments on the plugins!
Super cool stuff!
plugin-custom-directives.mjs
Outdated
| name: "youShouldNotice", | ||
| doc: "Renders a consistent callout when the learner should notice something.", | ||
| body: { | ||
| type: String |
There was a problem hiding this comment.
Suggested change
| type: String | |
| type: 'myst' |
Member
Author
There was a problem hiding this comment.
Dope, that's really useful to know. Thank you Rowan! ❤️
mfisher87
force-pushed
the
module-5-continued
branch
2 times, most recently
from
f8fc8b5 to
f5b3942
Compare
Co-authored-by: Rowan Cockett <913249+rowanc1@users.noreply.github.com>
…to parse Co-authored-by: Rowan Cockett <913249+rowanc1@users.noreply.github.com>
mfisher87
force-pushed
the
module-5-continued
branch
from
057ed96 to
8ce6f46
Compare
Member
Author
|
Thanks @rowanc1 for the review 🙇 |
rowanc1
reviewed
Nov 27, 2025
Comment on lines
31
to
55
| const youShouldNoticeDirective = { | ||
| name: "youShouldNotice", | ||
| doc: "Renders a consistent callout when the learner should notice something.", | ||
| body: { | ||
| type: 'myst', | ||
| }, | ||
| run(data) { | ||
| return [{ | ||
| type: "admonition", | ||
| kind: "important", | ||
| icon: false, | ||
| class: "simple", | ||
| children: [ | ||
| { | ||
| type: "admonitionTitle", | ||
| children: [{ | ||
| type: "text", | ||
| value: "👀 You should notice...", | ||
| }], | ||
| }, | ||
| ...data.body, | ||
| ], | ||
| }]; | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Nice - IMO this is about as simple as it can be..!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds content for module 5 exercises C-E.
I was finding myself repeating a lot of stuff, so I extracted a couple of plugins to reduce repetition, and documented their usage in the style guide and a new "helpers" page.
I also added commit checkpoints throughout and a dropdown callout for folks who might be joining the workshop late.
🔍 Preview: https://geojupyter-workshop-open-source-geospatial--48.org.readthedocs.build/
Note: This Pull Request preview is provided by ReadTheDocs. Our production website, however, is currently deployed with GitHub Pages.