Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEL]: Fix size of share links #1117

Merged
merged 2 commits into from
Feb 13, 2025
Merged

[MEL]: Fix size of share links #1117

merged 2 commits into from
Feb 13, 2025

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Feb 12, 2025

Description

This PR adds an extraClass to the gn-ui-data-view-share component, which has no impact on the display of the component in gn-ui, but will allow the webcomponent on MEL to be stretched all the way across the preview square (see https://mel.integration.apps.gs-fr-prod.camptocamp.com/catalogue/dataset/ville-roubaix::activit%C3%A9-sportive-sport-pass-roubaix).
Removing the container-lg and lg:mx-auto for the MEL fixes that.

Architectural changes

none

Screenshots

no UI changes

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Feb 12, 2025

Affected libs: feature-record,
Affected apps: datahub,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Feb 12, 2025

📷 Screenshots are here!

Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmoinier, good find! The change makes sense to me :-)

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes sense as a component such as gn-ui-data-view-share should not have this kind of layout responsibility. Thanks! Just made a suggestion regarding where to put those layout classes

@cmoinier cmoinier merged commit e01cfe9 into main Feb 13, 2025
12 checks passed
@cmoinier cmoinier deleted the fix-mel-share-links branch February 13, 2025 12:37
@coveralls
Copy link

Coverage Status

coverage: 84.205% (+0.01%) from 84.193%
when pulling d82fcd5 on fix-mel-share-links
into a28bdab on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants