-
-
Notifications
You must be signed in to change notification settings - Fork 298
Normalize CRS handling #2116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
webb-ben
wants to merge
12
commits into
geopython:master
Choose a base branch
from
webb-ben:crs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Normalize CRS handling #2116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@justb4 @MTachon @doublebyte1 @tomkralidis any thoughts on this? |
I will take a look/review on the weekend. |
Update: note that I'm still reviewing and will provide feedback in the next day or two (cc @justb4). |
@webb-ben can you rebase? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
pygeoapi/crs.py
. Moved code frompygeoapi/api/__init__.py
,pygeoapi/api/itemtypes.py
,pygeoapi/util.py
, and various providers. Much of this code was near duplicate with small differences, making it very hard to track consistent CRS across pygeoapi;always_xy
CRS configuration option.storage_crs
option in base provider. (To allow a future PR to also subsume mapscript options.projection with the normative configuration vocabulary)I am holding off from overly mutating the implementation of OACov and OAMap because this branch is already getting to a sizable diff. Very little code was changed, and was mostly just merged from various files into
crs.py
andtest_crs.py
. I am working on clarifying CRS handling in pygeoapi as well as documenting the changes within the docs right now.Related Issue / discussion
Addresses: #2102, #2010
Additional information
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)