Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add column containing ultimate parent #6

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Add column containing ultimate parent #6

merged 2 commits into from
Mar 4, 2024

Conversation

jmelot
Copy link
Member

@jmelot jmelot commented Mar 4, 2024

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

No need for rebasing 👍
behind_count is 0
ahead_count is 2

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
62 29 47% 0% 🟢

New Files

File Coverage Status
ror_scripts/get_ultimate_parent.py 35% 🟢
tests/test_get_ultimate_parent.py 100% 🟢
TOTAL 68% 🟢

Modified Files

No covered modified files...

updated for commit: 099970a by action🐍

@jmelot jmelot marked this pull request as ready for review March 4, 2024 16:58
niharikasingh
niharikasingh approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@niharikasingh niharikasingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@niharikasingh niharikasingh merged commit 77d452e into main Mar 4, 2024
3 checks passed
@niharikasingh niharikasingh deleted the add-ultimate-parent branch March 4, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niharikasingh niharikasingh niharikasingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmelot @niharikasingh