[WIP] Partial implementation of the MVT writer#181
Draft
nyurik wants to merge 1 commit intogeorust:mainfrom
Draft
[WIP] Partial implementation of the MVT writer#181nyurik wants to merge 1 commit intogeorust:mainfrom
nyurik wants to merge 1 commit intogeorust:mainfrom
Conversation
Member
|
Hey @nyurik - any particular hold up that caused this to stall out or just the ole' problem of "time and energy is finite" Any plans to continue with this in the near term? |
Member
Author
|
@michaelkirk well put :) I would LOVE to work on it, but would need to find time, so if you want to take over that, please do. It is, sadly, not as trivial as I was hoping. BTW, totally unrelated, but an important heads-up: MapLibre is actively working with various players (like Microsoft) on the next generation of the tile spec, most likely based on the in-progress work by Markus in https://github.com/mactrem/cov-tiles |
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
…outputting layers (#264) - [x] I agree to follow the project's [code of conduct](https://github.com/georust/.github/blob/main/CODE_OF_CONDUCT.md). - [x] I added an entry to the project's change log file if knowledge of this change could be valuable to users. - Usually called `CHANGES.md` or `CHANGELOG.md` - Prefix changelog entries for breaking changes with "BREAKING: " --- This is an implementation of feature writing for MVTs, as discussed in #263. This PR builds upon @nyurik's previous WIP reimplementation #181. It passes all of the `mvt_writer` tests. I am not sure if I understood the API exactly correctly but this seems to be a pretty good starting point, as individual feature/geom can be converted to a MVT feature with the `ToMvt` trait as well as `MvtWriter` can process multiple feature and output them to a layer. [Here is an example](https://github.com/maplibre/martin/blob/20ff5e36cc89bb07aefaf39a6f513df6b65a38cc/martin/src/geojson/mod.rs#L124) of feature writing and layer output with MvtWriter (from GeoJSON to MVT tiles PR, maplibre/martin#2098) Let me know how we can move forward with this PR. --------- Co-authored-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimenting with MVT writer implementation to support property generation