feat(cli): Add support for geoparquet reading#247
feat(cli): Add support for geoparquet reading#247alekzvik wants to merge 5 commits intogeorust:mainfrom
Conversation
|
Hello! I am new to rust and georust community and I did not find any contribution guidelines, so please let me know if anything can be improved. |
kylebarron
left a comment
kylebarron
left a comment
There was a problem hiding this comment.
This looks perfect! Indeed the RecordBatchReader is the right option; I should've suggested that previously.
I'm hoping to release geoarrow 0.4 within a couple weeks, but I don't expect it to change much from the latest beta, and certainly not any of these APIs.
| Some("jsonl") | Some("geojsonl") => { | ||
| GeozeroDatasource::process(&mut GeoJsonLineReader::new(filein), processor) | ||
| } | ||
| Some("parquet") | Some("geoparquet") => { |
There was a problem hiding this comment.
The community discourages against .geoparquet as a file extension, but I figure it's fine to accept files with the suffix.
There was a problem hiding this comment.
I do not have a strong opinion here, and tried to be consistent with json/geojson and also with stacrs CLI which also supported both.
|
Note that due to compiler regressions: geoarrow/geoarrow-rs#716, rust-lang/rust#128887, rust-lang/rust#131960 this will fail to compile with to install from this branch |
|
geoarrow/geoarrow-rs#956 works around the compiler regression, so the next release of |
|
I published geoarrow 0.4.0-beta.3 (https://crates.io/crates/geoarrow/0.4.0-beta.3) which lets you build without the nightly API. You can test out that beta release if you'd like. I'll publish geoarrow 0.4 in early January. It might be simplest to wait to merge this PR until then |
|
Any update @kylebarron? |
|
I've been swamped and working on another project, and haven't been able to release a new version |
|
I forgot about this. 😓 @kylebarron - it looks like 0.4 (and 0.5, 0.6) have been released in the last year. Does that mean this can move forward now with stable rust? |
|
Correct, you should only need stable rust for any current release of |
3 participants
Add support for reading geoparquet files in the CLI.
Closes #242
There is additional discussion and pointers in the linked ticket.