Remove geo benchmarks and fix benchmark API usage #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix up remaining benchmarks to conform to new API
1 task
Member
Author
|
Closing in favour of #207 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 18, 2025
- [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - [n/a] I added an entry to `rstar/CHANGELOG.md` if knowledge of this change could be valuable to users. --- Alternative to #206 Rather than removing the bench as in #206, remove the `geo` dependency. We were only using geo:MapCoords, and in this case I think "a little copying is better than a little dependency".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix up remaining benchmarks to conform to new API
rstar/CHANGELOG.mdif knowledge of this change could be valuable to users.As we can see in the currently-failing tests in #204, running our tests using the patch directive in
Cargo.tomlcauses a failure due to therstar-benchespackage depending ongeodue to the API change in #189 (if I've understood the issue correctly).We could fix this by:
geoversiongeoversionAlternatively, we can remove the benchmarks that use
geoand remove thegeodependency fromrstar-benches(optionally moving them intogeo-types).