Skip to content

Conversation

@1Dandan
Copy link

@1Dandan 1Dandan commented Oct 27, 2025

Name and Institution (Required)

Name: Dandan Zhang
Institution: Harvard University

Describe the update

To fix the regridding error when the target latitude or longitude is exactly 0.0

Expected changes

It will work for stretched GCHP regridding when the target latitude or longitude is exactly 0.0.

Reference(s)

N/A

Related Github Issue

#384

@yantosca yantosca self-requested a review October 28, 2025 14:12
@yantosca yantosca self-assigned this Oct 28, 2025
@yantosca yantosca added topic: Regridding Issues pertaining to horizontal & vertical regridding category: Bug Fix Fixes a bug that was previously reported labels Oct 28, 2025
@yantosca yantosca added this to the 1.7.0 milestone Oct 28, 2025
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @1Dandan, this looks good but we just need a CHANGELOG.md update.

Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @1Dandan, good to merge!

yantosca added a commit that referenced this pull request Oct 28, 2025
This merge brings PR # (Fix the regridding error when
the target latitude or longitude is exactly 0.0, by @1Dandan)
into the GCPy 1.7.0 development stream.

PR #385 updates an if statement to use test for "None" instead
of "not", thus avoiding an error when the target latitude
or longitude is exactly zero.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca
Copy link
Contributor

NOTE: I forgot to change the base branch. This feature branch has been merged into dev, but the PR will show as merged once we merge dev into main.

@msulprizio msulprizio requested a review from lizziel October 29, 2025 14:19
Copy link
Contributor

@lizziel lizziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: Bug Fix Fixes a bug that was previously reported topic: Regridding Issues pertaining to horizontal & vertical regridding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants