Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update babel and eslint #10005

Open
offtherailz opened this issue Feb 29, 2024 · 3 comments · May be fixed by #10006
Open

Update babel and eslint #10005

offtherailz opened this issue Feb 29, 2024 · 3 comments · May be fixed by #10006
Assignees
@offtherailz
Labels
enhancement investigation
Milestone
2025.01.00

Comments

@offtherailz
Copy link
Member

Description

A recent PR sent to a project asked to update babel (and so dependent plugins/eslint) to fix a build problem on mac.
We should port this Version update on MapStore core.

Trying to do it, we have several errors in eslint (due to old bugs of eslint not revealing some items) alrady notified in the past by @MV88 (see this and this

This issue want to propose an update strategy for it, as easy as possible.
@offtherailz offtherailz self-assigned this Feb 29, 2024
@offtherailz
Copy link
Member Author

(goint to report my findings soon @tdipisa

offtherailz added a commit to offtherailz/MapStore2 that referenced this issue Mar 1, 2024
@offtherailz
geosolutions-it#10005 update babel configuration
9e3cd72
@offtherailz offtherailz linked a pull request Mar 1, 2024 that will close this issue
Open
12 tasks
@offtherailz
Copy link
Member Author

offtherailz commented Mar 1, 2024 •
edited
Loading

@tdipisa please see my proposed solution here:
#10006

I think it can be reviewed. I preferred to finalize the PR right now that I'm on the problem. As well as my PR is approved by the team I can proceed publishing the eslint config lib on npm and make the build pass.

@tdipisa
Copy link
Member

tdipisa commented Mar 1, 2024

@tdipisa please see my proposed solution here: #10006

I think it can be reviewed. I preferred to finalize the PR right now that I'm on the problem. As well as my PR is approved by the team I can proceed publishing the eslint config lib on npm and make the build pass.

@offtherailz let's discuss briefly before

@tdipisa tdipisa mentioned this issue Mar 4, 2024
Closed
1 task
@tdipisa tdipisa added this to the 2025.01.00 milestone Oct 2, 2024
offtherailz added a commit to offtherailz/MapStore2 that referenced this issue Oct 14, 2024
@offtherailz
Fix geosolutions-it#10005 update babel configuration
523de31
offtherailz added a commit to offtherailz/MapStore2 that referenced this issue Oct 14, 2024
@offtherailz
Fix geosolutions-it#10005 update babel configuration
28e0472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@offtherailz offtherailz

Labels
enhancement investigation
Projects
None yet
Milestone
2025.01.00
Development

Successfully merging a pull request may close this issue.

#10005 update babel configuration offtherailz/MapStore2
2 participants
@offtherailz @tdipisa