-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10005 update babel configuration #10006
Open
offtherailz
wants to merge
7
commits into
geosolutions-it:master
Choose a base branch
from
offtherailz:10005
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offtherailz
commented
Mar 1, 2024
@offtherailz we are too close to 2024.01.00 so the plan would be to include this to the next major 2024.02. Let's update this PR and merge on master early after 2024.01 is delivered |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: in order to make this PR build correctly, we need to publish eslint node lib. I published it
As explained in 10005 updating babel needs to update eslint too, and this causes several lint error because of old bugs of eslint not revealing the failing parts.
Here I attach the full set of errors.
eslint-errors.txt
The errors can be divided in 2 macro-blocks:
componentDidMount
)For this reason I propose the following:
We can evaluate to re-introduce the rule of proptypes later and fix the pending eslint errors disabled, but this way we guarantee:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Fix #10005
What is the new behavior?
Babel updated. Eslint rule catch now finds errors that was not visible before.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
I also fixes some require/exports to avoid some lint errors too.
I noticed babel plugin
plugin-proposal-class-properties
is deprecated and we should useplugin-transform-class-properties
instead.I didn't do this update in this PR, concentrating the effort to a working solution.