-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #10530 fix catalog editor for array scenario #10531
Conversation
@MV88 there is a failing test which is not depending on this PR. @offtherailz will check it during review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using the first URL, An error should be shown because the format with array is not supported, and so it is error prone.
Please show misconfiguration error.
done, please review again |
354a560
to
a7fe147
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The catalog still works for some reason in search, while gives error in the editor, as expected
even if not properly consistent, I think that it is enough for a misconfiguration, that by definition can have inconsistent results.
Description
fixing case when catalog url service is array, all details in issue
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Fix #10530
What is the new behavior?
no crash in case of array
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information