Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog editor i18n #10571

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

tha-nordiq
Copy link
Contributor

Description

Move url placeholders from hard coded values in MainFormUtils.js and MainForm.jsx to language files to allow i18n.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: i18n

Issue

What is the current behavior?
The url placeholders are always in english "e.g. https://mydomain.com/geoserver/wms"

What is the new behavior?
Now the url placeholders can be translated. Translations added for danish, german and spanish
"f.eks. https://mydomain.com/geoserver/wms"

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@tdipisa tdipisa added this to the 2024.02.01 milestone Sep 27, 2024
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 8, 2024
@offtherailz offtherailz merged commit 08772cd into geosolutions-it:master Oct 21, 2024
6 checks passed
@offtherailz
Copy link
Member

@tha-nordiq thank you very much for contributing MapStore ❤️

offtherailz pushed a commit to offtherailz/MapStore2 that referenced this pull request Oct 21, 2024
rmelarab-ngs pushed a commit to ngsllc/MapStore2 that referenced this pull request Nov 5, 2024
tdipisa pushed a commit that referenced this pull request Nov 13, 2024
Co-authored-by: Thomas Hallundbæk <72447095+tha-nordiq@users.noreply.github.com>
@tdipisa tdipisa modified the milestones: 2024.02.01, 2024.02.02 Nov 13, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants