Add support for QML style from QGIS 3.28 #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS so far this PR only contains src/ and data/ changes. |
|
@KaiVolland can you take a look? |
I'm actually not sure why dist is not in .gitignore. Usually this should be covered by the pipeline. |
KaiVolland
reviewed
Dec 11, 2024
|
Thanks for the contribution. 🙏 Just a minor note with a possible improvement. |
Tests should read both pre-3.28 QML - from data/qmls_old and, post-3.28 QML - stored in data/qmls When writing, the output should be 3.28 compatible. This only sets up the new text structure - the test data and conversion logic is not yet updated to be 3.28 compatible.
and to read both 3.28 style QML, and earlier style QML Update test data in qmls/ to be 3.28 style QML
olsen232
force-pushed
the
olsen-support-qgis3.28
branch
from
a5193b2 to
dac4475
Compare
KaiVolland
approved these changes
Dec 12, 2024
|
Just FYI: I reworded your commit messages and force pushed to the main branch again. This is breaking change and it's my bad that i didn't notice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #455
Fixes #455
Fixes #540
Fixes #541
Changes to conversion logic are basically the same as in previous attempt by geographika:
#569
it's only a very minor change to the conversion logic that is needed, so can't go too far wrong.
However, updated test data is quite different to that supplied by geographika - test data is mostly limited to the properties that we actually read and write (consistent with the old test data now in
data/qmls_old) and not the complete output of QGIS, which tends to have a lot of noise that we can't parse and don't care about.TESTED=tests pass, test data in both
data/qmlsanddata/qmls_oldcan be understood by my QGIS-3.34 on macos.