Feat(GPX-669):Multena: Add TLS support for datasources #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Lucostus
commented
Jul 13, 2023
Lucostus
commented
- adapted to new config structure
- mount tls-secrets to the right location
- added kyverno policies to copy the tls secret from the appropriate namespaces
# Conflicts: # infra/gp-multena/Chart.yaml # infra/gp-multena/templates/system-datasources.yaml # infra/gp-multena/values.yaml
Lucostus
requested review from
fhochleitner
and removed request for
fhochleitner
fhochleitner
suggested changes
Jul 17, 2023
| @@ -87,6 +95,16 @@ spec: | |||
| secret: | |||
| secretName: {{ include "gp-multena.secretName" . }} | |||
| {{- end }} | |||
| {{- if eq .Values.tlsCopy.loki.enabled true }} | |||
There was a problem hiding this comment.
bin mir nicht sicher, ob wir das mounting des secrets an das kopieren koppeln wollen.
kann ja sein, dass der proxy verwendet werden möchte, ohne kyverno am cluster zu haben und die:der anwender:in das zertifikat manuell überspielt, oder?
| secret: | ||
| secretName: {{ .Values.tlsCopy.loki.secretName }} | ||
| {{- end }} | ||
| {{- if eq .Values.tlsCopy.thanos.enabled true }} |
fhochleitner
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.