Skip to content

chore(deps): bump actions/checkout from 3 to 4 (#265) #268

chore(deps): bump actions/checkout from 3 to 4 (#265)

chore(deps): bump actions/checkout from 3 to 4 (#265) #268

GitHub Actions / clippy succeeded Nov 13, 2023 in 3s

clippy

195 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 195
Note 0
Help 0

Versions

  • rustc 1.76.0-nightly (2b603f95a 2023-11-12)
  • cargo 1.76.0-nightly (6790a5127 2023-11-10)
  • clippy 0.1.75 (2b603f9 2023-11-12)

Annotations

Check warning on line 13 in eventually-macros/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
  --> eventually-macros/src/lib.rs:13:1
   |
13 | pub fn derive_message(input: TokenStream) -> TokenStream {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: the lint level is defined here
  --> eventually-macros/src/lib.rs:4:9
   |
4  | #![warn(missing_docs)]
   |         ^^^^^^^^^^^^

Check warning on line 63 in eventually-macros/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for function which may panic missing `# Panics` section

warning: docs for function which may panic missing `# Panics` section
  --> eventually-macros/src/lib.rs:63:1
   |
63 | pub fn aggregate_root(args: TokenStream, item: TokenStream) -> TokenStream {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: first possible panic found here
  --> eventually-macros/src/lib.rs:68:26
   |
68 |       let aggregate_type = args
   |  __________________________^
69 | |         .first()
70 | |         .and_then(|meta| match meta {
71 | |             NestedMeta::Meta(Meta::Path(Path { segments, .. })) => Some(segments),
...  |
75 | |         .map(|segment| segment.ident.clone())
76 | |         .expect("the aggregate root type must be provided as macro parameter");
   | |______________________________________________________________________________^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

Check warning on line 61 in eventually-macros/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item in documentation is missing backticks

warning: item in documentation is missing backticks
  --> eventually-macros/src/lib.rs:61:36
   |
61 | /// through [std::ops::Deref] and [std::ops::DerefMut].
   |                                    ^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
   |
61 | /// through [std::ops::Deref] and [`std::ops::DerefMut`].
   |                                    ~~~~~~~~~~~~~~~~~~~~

Check warning on line 61 in eventually-macros/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item in documentation is missing backticks

warning: item in documentation is missing backticks
  --> eventually-macros/src/lib.rs:61:14
   |
61 | /// through [std::ops::Deref] and [std::ops::DerefMut].
   |              ^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
   |
61 | /// through [`std::ops::Deref`] and [std::ops::DerefMut].
   |              ~~~~~~~~~~~~~~~~~

Check warning on line 46 in eventually-macros/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item in documentation is missing backticks

warning: item in documentation is missing backticks
  --> eventually-macros/src/lib.rs:46:19
   |
46 | /// user-defined [eventually::aggregate::Aggregate] types.
   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
   |
46 | /// user-defined [`eventually::aggregate::Aggregate`] types.
   |                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 45 in eventually-macros/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item in documentation is missing backticks

warning: item in documentation is missing backticks
  --> eventually-macros/src/lib.rs:45:38
   |
45 | /// Implements a newtype to use the [eventually::aggregate::Root] instance with
   |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
   = note: `#[warn(clippy::doc_markdown)]` implied by `#[warn(clippy::pedantic)]`
help: try
   |
45 | /// Implements a newtype to use the [`eventually::aggregate::Root`] instance with
   |                                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 24 in eventually-macros/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
  --> eventually-macros/src/lib.rs:24:26
   |
24 |         let event_name = format!("{}{}", event_prefix, event_type);
   |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
   = note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::pedantic)]`
help: change this to
   |
24 -         let event_name = format!("{}{}", event_prefix, event_type);
24 +         let event_name = format!("{event_prefix}{event_type}");
   |

Check warning on line 13 in eventually-macros/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for function which may panic missing `# Panics` section

warning: docs for function which may panic missing `# Panics` section
  --> eventually-macros/src/lib.rs:13:1
   |
13 | pub fn derive_message(input: TokenStream) -> TokenStream {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: first possible panic found here
  --> eventually-macros/src/lib.rs:16:24
   |
16 |       let event_prefix = item_name
   |  ________________________^
17 | |         .to_string()
18 | |         .strip_suffix("Event")
19 | |         .unwrap()
   | |_________________^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
note: the lint level is defined here
  --> eventually-macros/src/lib.rs:6:9
   |
6  | #![warn(clippy::pedantic)]
   |         ^^^^^^^^^^^^^^^^
   = note: `#[warn(clippy::missing_panics_doc)]` implied by `#[warn(clippy::pedantic)]`

Check warning on line 7 in eventually/src/version.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct field

warning: missing documentation for a struct field
 --> eventually/src/version.rs:7:5
  |
7 |     pub actual: Version,
  |     ^^^^^^^^^^^^^^^^^^^

Check warning on line 6 in eventually/src/version.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct field

warning: missing documentation for a struct field
 --> eventually/src/version.rs:6:5
  |
6 |     pub expected: Version,
  |     ^^^^^^^^^^^^^^^^^^^^^

Check warning on line 5 in eventually/src/version.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
 --> eventually/src/version.rs:5:1
  |
5 | pub struct ConflictError {
  | ^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 1 in eventually/src/version.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
 --> eventually/src/version.rs:1:1
  |
1 | pub type Version = u64;
  | ^^^^^^^^^^^^^^^^

Check warning on line 38 in eventually/src/serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a trait

warning: missing documentation for a trait
  --> eventually/src/serde.rs:38:1
   |
38 | pub trait Serde<T>: Serializer<T> + Deserializer<T> {}
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 24 in eventually/src/serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
  --> eventually/src/serde.rs:24:5
   |
24 |     fn deserialize(&self, data: Vec<u8>) -> Result<T, Self::Error>;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 22 in eventually/src/serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for an associated type

warning: missing documentation for an associated type
  --> eventually/src/serde.rs:22:5
   |
22 |     type Error;
   |     ^^^^^^^^^^

Check warning on line 21 in eventually/src/serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a trait

warning: missing documentation for a trait
  --> eventually/src/serde.rs:21:1
   |
21 | pub trait Deserializer<T> {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 9 in eventually/src/serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
 --> eventually/src/serde.rs:9:5
  |
9 |     fn serialize(&self, value: T) -> Vec<u8>;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 8 in eventually/src/serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a trait

warning: missing documentation for a trait
 --> eventually/src/serde.rs:8:1
  |
8 | pub trait Serializer<T> {
  | ^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 27 in eventually/src/message.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
  --> eventually/src/message.rs:25:5
   |
25 | /     pub fn and_metadata<F>(mut self, f: F) -> Self
26 | |     where
27 | |         F: Fn(&mut Metadata),
   | |_____________________________^

Check warning on line 17 in eventually/src/message.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct field

warning: missing documentation for a struct field
  --> eventually/src/message.rs:17:5
   |
17 |     pub metadata: Metadata,
   |     ^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 16 in eventually/src/message.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct field

warning: missing documentation for a struct field
  --> eventually/src/message.rs:16:5
   |
16 |     pub message: T,
   |     ^^^^^^^^^^^^^^

Check warning on line 12 in eventually/src/message.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> eventually/src/message.rs:12:1
   |
12 | pub struct Envelope<T>
   | ^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 9 in eventually/src/message.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
 --> eventually/src/message.rs:9:1
  |
9 | pub type Metadata = HashMap<String, String>;
  | ^^^^^^^^^^^^^^^^^

Check warning on line 6 in eventually/src/message.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
 --> eventually/src/message.rs:6:5
  |
6 |     fn name(&self) -> &'static str;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 5 in eventually/src/message.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a trait

warning: missing documentation for a trait
 --> eventually/src/message.rs:5:1
  |
5 | pub trait Message {
  | ^^^^^^^^^^^^^^^^^