fix: Do not accept channel collaborative close offer on reconnect. #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dlc channel will be updated to `CollaborativeCloseOffered` if the collab closed has been offered (by the offering party). Hence it is wrong to interpret the state `SignedChannelState::CollaborativeCloseOffered` as pending offer.
bonomat
approved these changes
Feb 8, 2024
|
I think that fix is not correct. |
auto-merge was automatically disabled
February 8, 2024 13:03
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dlc channel will be updated to
CollaborativeCloseOfferedif the collab closed has been offered (by the offering party).Hence it is wrong to interpret the state
SignedChannelState::CollaborativeCloseOfferedas pending offer.fixes #1973