Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: the maker is dead, long live the maker #2026

Merged

Conversation

bonomat
Copy link
Contributor

@bonomat bonomat commented Feb 13, 2024

If you have been running the maker using just then nothing should change for you.

  • just maker: starts the maker attached
  • just run-maker-detached: starts the maker detached

Note the maker image is public at the moment, hence, there is no login required.

@bonomat bonomat requested review from holzeis and luckysori February 13, 2024 12:41
@bonomat bonomat force-pushed the chore/the-maker-is-dead-long-live-the-maker branch 2 times, most recently from 9c71112 to 15856f0 Compare February 13, 2024 13:36
Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@bonomat bonomat force-pushed the chore/the-maker-is-dead-long-live-the-maker branch 2 times, most recently from fb459ac to 2fd8a40 Compare February 13, 2024 15:10
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
@bonomat bonomat force-pushed the chore/the-maker-is-dead-long-live-the-maker branch from 2fd8a40 to 624cb6b Compare February 13, 2024 15:31
@bonomat bonomat added this pull request to the merge queue Feb 14, 2024
Merged via the queue into get10101:main with commit 94ca4df Feb 14, 2024
20 checks passed
@bonomat bonomat deleted the chore/the-maker-is-dead-long-live-the-maker branch February 14, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants