-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade flutter to 3.19.1 #2081
Conversation
a5654e0
to
9117f6d
Compare
@holzeis : fixed the firefox issue in |
Two more things.
|
using the CanvasKit seems to make problems in the browser even though it's meant to provide better performance. > CanvasKit renderer > This renderer is fully consistent with Flutter mobile and desktop, has faster performance with higher widget density, but adds about 1.5MB in download size. CanvasKit uses WebGL to render Skia paint commands. However, for us it just makes problems. We might want to revisit this decision in the future. Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
e43730f
to
68bc1d6
Compare
@holzeis :
I'm giving up on this :/ Might be better to spend some time replacing the carousel but I don't have the nerves for this right now.
This is fixed: |
Maybe this gets "fixed" if we switch back to the previous font and size. |
Be my guest figuring out what it was before and setting it to this value now 🙈 |
to avoid overlapping of the position Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
2a3f261
to
bdc5e32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just looking at the diff.
Although I was confused because I thought we were tackling #1777 haha.
child: Container( | ||
padding: const EdgeInsets.all(18), | ||
decoration: BoxDecoration( | ||
borderRadius: BorderRadius.circular(8), | ||
color: Colors.grey[100], | ||
// color: Colors.grey[100], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 I guess we can remove this.
resolves #1924
Note: