Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollover): Remove outdated rollover recovery logic #2144

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

holzeis
Copy link
Contributor

@holzeis holzeis commented Mar 4, 2024

The recovery logic has been replaced generally with retrying to send the last_outbound_dlc_message this also applies to the rollover. Hence we should not rollback to the latest state if the app reconnects in an intermediate state.

fixes #2137

@holzeis holzeis requested review from bonomat and luckysori March 4, 2024 09:26
@holzeis holzeis self-assigned this Mar 4, 2024
Copy link
Contributor

@luckysori luckysori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@holzeis holzeis added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit fbabd84 Mar 4, 2024
21 checks passed
@holzeis holzeis deleted the fix/remove-outdated-rollover-recovery-logic branch March 4, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollover failed with a reconnect after accepting renew offer
2 participants