dev/app: A few fixes and clean-ups #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, pipe logs into file Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
This is needed so that one can open/close/open/close quickly after each other without using all the liquidity. This is done in at least 1 e2e test Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
this ensures we always have orders in the orderbook Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
for better readability Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
luckysori
approved these changes
Mar 22, 2024
crates/commons/src/price.rs
Outdated
Comment on lines
46
to
55
| fn best_bid_price(orders: &[Order], symbol: ContractSymbol) -> Option<Decimal> { | ||
| orders | ||
| .iter() | ||
| .filter(|o| { | ||
| o.order_state == OrderState::Open | ||
| && o.direction == Direction::Long | ||
| && o.contract_symbol == symbol | ||
| }) | ||
| .map(|o| o.price) | ||
| .max() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with flaky e2e tests and improve the dev experience as well as fix a problem where we saw expired orders in the app.