Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove lightning and sub channels remnants #2490

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

holzeis
Copy link
Contributor

@holzeis holzeis commented Apr 28, 2024

feels good :)

fixes #2013
fixes #2015

@holzeis holzeis requested review from bonomat and luckysori April 28, 2024 18:17
@holzeis holzeis self-assigned this Apr 28, 2024
@holzeis holzeis force-pushed the refactor/combine-common-crates branch from be3e749 to 2833125 Compare April 28, 2024 18:26
@holzeis holzeis force-pushed the refactor/remove-lightning-and-subchannel-remnants branch from f6cdd6d to 0d98fc3 Compare April 28, 2024 18:28
Copy link
Contributor

@luckysori luckysori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK. I assume the diff is trivially removing stuff.

@holzeis
Copy link
Contributor Author

holzeis commented Apr 29, 2024

Concept ACK. I assume the diff is trivially removing stuff.

Mostly trivial, I had to change the PeerManager type and initialisation.

@holzeis holzeis force-pushed the refactor/combine-common-crates branch from 2833125 to 6d96e67 Compare April 29, 2024 06:48
@holzeis holzeis force-pushed the refactor/remove-lightning-and-subchannel-remnants branch from 0d98fc3 to 0703300 Compare April 29, 2024 06:49
Base automatically changed from refactor/combine-common-crates to main April 29, 2024 08:07
@holzeis holzeis force-pushed the refactor/remove-lightning-and-subchannel-remnants branch from 0703300 to 91ea843 Compare April 29, 2024 08:12
@holzeis holzeis added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit d4cce7c Apr 29, 2024
22 checks passed
@holzeis holzeis deleted the refactor/remove-lightning-and-subchannel-remnants branch April 29, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants