fix: remove any chance of being able to concurrently call start funct…

…ion (#468)

api/api.go

@@ -9,6 +9,7 @@ import (
 	"net/http"
 	"net/url"
 	"strings"
+	"sync"
 	"time"
 
 	"github.com/sirupsen/logrus"
@@ -579,7 +580,14 @@ func (api *api) SetNextBackupReminder(backupReminderRequest *BackupReminderReque
 	return nil
 }
 
+var startMutex sync.Mutex
+
 func (api *api) Start(startRequest *StartRequest) error {
+	if !startMutex.TryLock() {
+		// do not allow to start twice in case this is somehow called twice
+		return errors.New("app is already starting")
+	}
+	defer startMutex.Unlock()
 	return api.svc.StartApp(startRequest.UnlockPassword)
 }
 

service/start.go

@@ -103,6 +103,9 @@ func (svc *service) StartNostr(ctx context.Context, encryptionKey string) error
 }
 
 func (svc *service) StartApp(encryptionKey string) error {
+	if svc.lnClient != nil {
+		return errors.New("app already started")
+	}
 	if !svc.cfg.CheckUnlockPassword(encryptionKey) {
 		logger.Logger.Errorf("Invalid password")
 		return errors.New("invalid password")