[WIP] docker: add docker-compose for testing validators and nodes #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutelin
force-pushed
the
feature/add-dockercompose-for-testing
branch
4 times, most recently
from
4541454 to
417acab
Compare
yutelin
force-pushed
the
feature/add-dockercompose-for-testing
branch
3 times, most recently
from
1df92e8 to
f6620ea
Compare
yutelin
changed the title
bailantaotao
force-pushed
the
feature/add-dockercompose-for-testing
branch
from
f6620ea to
d33dd4f
Compare
alanchchen
force-pushed
the
feature/add-dockercompose-for-testing
branch
2 times, most recently
from
c6361aa to
7a8bbc7
Compare
bailantaotao
force-pushed
the
feature/add-dockercompose-for-testing
branch
2 times, most recently
from
d03d3e8 to
ff6e010
Compare
alanchchen
force-pushed
the
feature/add-dockercompose-for-testing
branch
from
ff6e010 to
4032bea
Compare
alanchchen
force-pushed
the
feature/add-dockercompose-for-testing
branch
from
4032bea to
1b5394f
Compare
bailantaotao
force-pushed
the
feature/add-dockercompose-for-testing
branch
from
1b5394f to
251c5a8
Compare
yutelin
pushed a commit
that referenced
this pull request
Jun 28, 2017
Check that msg.To() is not nil in GetVMEnv
yysung1123
pushed a commit
that referenced
this pull request
Oct 24, 2025
## Why this should be merged Automate renaming of the Go module from `github.com/ethereum/go-ethereum` to `github.com/ava-labs/libevm`. ## How this works Before starting this PR, I branched the `renamed-go-module` branch off `master` (the upstream geth branch; our default is called `main`). It has been protected to require PRs, which are automatically generated by the workflow introduced in this PR. The new workflow is designed to be manually dispatched with an input string of the commit hash to use as a source for renaming. On dispatch, it: 1. Checks out the source commit; 2. Renames the module; 3. Makes all necessary internal changes (e.g. import renaming); 4. Runs [smoke tests](https://en.wikipedia.org/wiki/Smoke_testing_(software)); 5. Commits the changes to a new branch; and 6. Opens a PR to merge the new branch into `renamed-go-module`. ### Intended usage When performing an upstream sync to pull in new geth code, this workflow will first be run against the geth commit we intend to merge. After the generated PR is merged, the `renamed-go-module` branch will be the one incorporated into `main`. Note that the `renamed-go-module` branch requires _two_ reviewers to approve. The user who dispatches the workflow SHOULD be one, with any other valid reviewer as the other. This is because a single-reviewer workflow would allow any user to update the `renamed-go-module` branch because the PR author is `github-actions`. ## How this was tested Inspection of the generated PR #57 as well as the [workflow run that generated it](https://github.com/ava-labs/libevm/actions/runs/11298471240/job/31427495426).
yysung1123
pushed a commit
that referenced
this pull request
Oct 24, 2025
## Why this should be merged #51 had a bug when checking whether or not to open a PR. I was originally blocking everything if _not_ on main instead of doing something if on it. The [manually dispatched run therefore didn't open a PR as expected](https://github.com/ava-labs/libevm/actions/runs/11299366394/job/31430160561). ## How this works Change `!=` to `==` ## How this was tested n/a Signed-off-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
yysung1123
pushed a commit
that referenced
this pull request
Oct 24, 2025
## Why this should be merged Signs commits for auto-renaming the Go module, originally introduced in #51 with unsigned commits that can't be merged to `main`. ## How this works Changes the commit action to use [`ghcommit`](https://github.com/planetscale/ghcommit), which was made specifically to allow for keyless signing (GitHub signs the commit). The workflow no longer opens a PR to the `renamed-go-module` branch as it's redundant and the generated branch can be used directly. The commit message includes the `workflow_dispatch` trigger branch as well as a hash of the workflow file for a complete audit trail. I removed the commented-out PR trigger as it's unnecessary. In development we can now just trigger the workflow on the dev branch. ## How this was tested Inspecting [the commit](ava-labs@572b8ab) generated by a [workflow run](https://github.com/ava-labs/libevm/actions/runs/11357025696/job/31589219847). It is identical in modifications to the one reviewed in #59.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick:
Build 4-validator:
Run 4-validator:
Build 4-validator-3-node:
Run 4-validator-3-node: