test: improve getblockheader rpc test
#607
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit add a utreexod miner node and a bitcoin-core node to the test so it can compare the outputs in some blocks and check if floresta is compliant with the bitcoin-core `getblockheader` rpc command. Follow-up of getfloresta#453.
This commit add a `get_blockheader` method for both `bitcoind` and `utreexod` rpc classes.
Davidson-Souza
added
code quality
Collaborator
Author
|
Maybe this could be closed in favor of #657 @Davidson-Souza, @luisschwab ? |
Member
Sure! |
github-project-automation
bot
moved this from Outstanding Pull Requests
to Implemented, tested
in RPC Saga
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
Follow-up the #453.
Notes to the reviewers
This PR add a utreexod miner node and a bitcoin-core node to the test so it can compare the outputs in some blocks and check if floresta is compliant with the bitcoin-core
getblockheaderrpc command.It's worth to mention that is related to #590 and #606.