Skip to content

Conversation

@jaoleal
Copy link
Collaborator

@jaoleal jaoleal commented Sep 8, 2025

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other:

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: Readme

Description and Notes

To avoid discussions and misunderstandings about utreexo itself the bips were written and are, at the time Im writing this PR, being merged.

This mentions bitcoin/bips#1923 to be enough to close #296

draft until bips are merged.

Contributor Checklist

  • I've followed the contribution guidelines
  • I've verified one of the following:
    • Ran just pcc (recommended but slower)
    • Ran just lint-features '-- -D warnings' && cargo test --release
    • Confirmed CI passed on my fork
  • I've linked any related issue(s) in the sections above

Finally, you are encouraged to sign all your commits (it proves authorship and guards against tampering—see How (and why) to sign Git commits and GitHub's guide to signing commits).

Copy link
Member

@JoseSK999 JoseSK999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK, I would wait to provide the actual merged BIP link

Also there's a random image that you added, an error?

@jaoleal
Copy link
Collaborator Author

jaoleal commented Sep 8, 2025

sry for the image, btw it was a benchmark of floresta building with --release.

it took only 43 seconds with 32 cores

@Davidson-Souza Davidson-Souza added the documentation Improvements or additions to documentation label Sep 8, 2025
@jaoleal jaoleal marked this pull request as draft September 8, 2025 19:24
@jaoleal
Copy link
Collaborator Author

jaoleal commented Sep 8, 2025

the links are broken rn but itll work when the PR get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants