feat!: add variants to ConnectionKind enum in floresta-wire
#636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidson-Souza
added
enhancement
Member
|
I think you should remove the |
qlrd
force-pushed
the
feat/improve-connection-kind-enums
branch
2 times, most recently
from
daffd22 to
db806d8
Compare
qlrd
force-pushed
the
feat/improve-connection-kind-enums
branch
2 times, most recently
from
091f3b6 to
60cc332
Compare
Davidson-Souza
requested changes
Sep 19, 2025
qlrd
force-pushed
the
feat/improve-connection-kind-enums
branch
2 times, most recently
from
1971cd9 to
eeae205
Compare
qlrd
force-pushed
the
feat/improve-connection-kind-enums
branch
from
eeae205 to
b352d21
Compare
Davidson-Souza
requested changes
Sep 29, 2025
qlrd
force-pushed
the
feat/improve-connection-kind-enums
branch
3 times, most recently
from
341dd71 to
611b980
Compare
qlrd
force-pushed
the
feat/improve-connection-kind-enums
branch
from
611b980 to
7373a2d
Compare
This commit add to the `ConnectionKind::Regular`, `ConnectionKind::Extra` and `ConnectionKind::Manual` variants 2 new subvariants `OutboundKind::OutboundFullRelay` and `OutboundKind::BlockRelayOnly`, as well add a `AddrFetch` to comply with Bitcoin-Core on the "connection_type" field of `getpeerinfo` rpc (we exclude here a `Inbound` type, this one do not make sense in Floresta). chore: remove `std::fmt::write` from `floresta-wire/src/p2p_wire/error.rs`
…ion type. This commit checks if the `kind` connection from floresta's `getpeerinfo` rpc is compliant with the `connection_type` from bitcoind's `getpeerinfo` rpc. Also fix some spell checks in old unrelated files.
qlrd
force-pushed
the
feat/improve-connection-kind-enums
branch
from
7373a2d to
8099e15
Compare
| def block_header(self, block_hash: str): | ||
| """ | ||
| Return a block header, given its hash. | ||
| Return the hash of a block, given it's hash. |
Collaborator
There was a problem hiding this comment.
This description seems a bit confusing. If the function receives a block hash and simply returns the same hash, the purpose is not very clear.
Collaborator
Author
There was a problem hiding this comment.
It not returns the same hash, it returns the header given its hash. Maybe without , and with the word blockheader?
Suggested change
| Return the hash of a block, given it's hash. | |
| Return a blockheader given its hash. |
Collaborator
There was a problem hiding this comment.
I think this looks better
Suggested change
| Return the hash of a block, given it's hash. | |
| Return the block header for the given block hash. |
Member
|
Needs rebase |
JoseSK999
reviewed
Dec 26, 2025
| /// | ||
| /// We automatically attempt to open [NodeContext::MAX_FULL_RELAY_PEERS] | ||
| /// using addresses from our [AddressMan]. | ||
| OutboundFullRelay(ServiceFlags), |
Member
There was a problem hiding this comment.
Nit: can you move this one to be below Feeler (and above BlockRelayOnly)
Member
|
@qlrd are you still working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description and Notes
This PR is a partial fix of #622, in the sense to define enum variants compliant to the
"connection_type"field returned by the bitcoin-core'sgetpeerinforpc.How to verify the changes you have done?
It add to the
ConnectionKind::Regular,ConnectionKind::ExtraandConnectionKind::Manualvariants 2 new subvariantsOutboundKind::OutboundFullRelayandOutboundKind::BlockRelayOnly, as well add aAddrFetch(theInboundtype is excluded since this one do not make sense in Floresta).