fix: cleanup test directories before running tests #766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #760 (mitigation)
Description and Notes
Currently, the cleanup of
/logsdirectory happens at the END of test execution and only if tests pass. This causes:This PR provides a temporary mitigation by making
/logscleanup conditional on the--preserve-data-dirflag, while keeping/dataunconditionally cleaned at start.Note: This is a partial fix. Complete resolution will come in a follow-up PR after #742 is merged, where cleanup logic will be migrated to the Python runner for better control over test data management.
How to verify the changes you have done?
Next Steps
After #742 is merged, I plan to submit a follow-up PR to:
Contributor Checklist
just pcc(skipped - changes are bash-only, validated manually)just lint-features '-- -D warnings' && cargo test --release(not applicable)Manual validation performed:
bash -n)--preserve-data-dirflag tested