rpcserver: Support named and null parameters, Review optionals on rpc internal methods, Stronger Response and Error codes #831
+1,177
−515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
cc @csgui Why i cant alter the name of the PR 😭 |
jaoleal
force-pushed
the
some_fixes_rpcserver
branch
from
766648c to
5cd9007
Compare
Collaborator
Author
|
Can someone with permission to alter the pr title fix it for me ? rpcserver: Support named and null parameters, Review optionals on rpc internal methods, Stronger Response and Error codes. |
Collaborator
Author
|
5cd9007 Unrelated test fail |
Davidson-Souza
added
RPC
Davidson-Souza
changed the title
csgui
suggested changes
Feb 7, 2026
csgui
suggested changes
Feb 7, 2026
Contributor
|
@jaoleal double check if you can use That would makes more sense and allows the remove of |
jaoleal
force-pushed
the
some_fixes_rpcserver
branch
2 times, most recently
from
c13b68a to
0e160f5
Compare
Collaborator
Author
|
top commit: 0e160f5
Thanks for the suggestions @csgui |
Collaborator
|
I think the commit descriptions are missing because they only have titles. |
jaoleal
force-pushed
the
some_fixes_rpcserver
branch
from
0e160f5 to
781ea91
Compare
Collaborator
Author
|
[781ea91 Rebased and extended commit message with descriptions. |
Collaborator
Author
|
Added formal |
jaoleal
force-pushed
the
some_fixes_rpcserver
branch
from
781ea91 to
994e4b7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jaoleal
force-pushed
the
some_fixes_rpcserver
branch
4 times, most recently
from
2d230a8 to
bd4d7a1
Compare
Collaborator
Author
|
gaddamit these conflicts |
These changes replaces error code literals to constants, being them http or jsonrpc error codes, as well creating methods to convert internal errors to them. That also brings a well-defined response type that matches jsonrpc spec.
…nd refact arg_parser. According the spec, jsonrpc 2.0 should be able to support flexible params definition, allowing them to be named or totally omitted inside the request, respecting the method definition and these changes present that support. Changes reflected in a refact of the internal arg_parser module, also creating better handles for optionals and params with default values.
…requests cases. The last commit presented some changes for the rpcserver and these tests assert them.
jaoleal
force-pushed
the
some_fixes_rpcserver
branch
from
bd4d7a1 to
d18e6dd
Compare
Collaborator
Author
|
unrelated fail on functional tests d18e6dd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Notes
Some time ago i was messing with the server trying to fix some pains that i had developing methods on it and i encountered some points to upgrade.
4839dc6 - fixes #827 by matching errors and returning constant values, i also mapped some custom error codes to internal errors as I understood that were allowed by the spec.
29220da- Adds named and null parameters support, I also reviewed some
Options in internal rpc methods that actually had internal defaults, created a getter for that case.fix #827
fix #704
How to verify the changes you have done?
Pushed some extensive tests regarding request and result parsing and behavior, checking that calls are accepted when expected and when refused we assert the error response.
Contributor Checklist
just pcc(recommended but slower)just lint-features '-- -D warnings' && cargo test --releaseFinally, you are encouraged to sign all your commits (it proves authorship and guards against tampering—see How (and why) to sign Git commits and GitHub's guide to signing commits).