Skip to content

Conversation

@jaoleal
Copy link
Collaborator

@jaoleal jaoleal commented Feb 9, 2026

Description and Notes

commit d10a898

feat(flake): use projects hooks instead of pre-commit.

The previous setup of pre-commit used rusts version from them, this often caused version bugs and instead of fixing that I took the approach of running our just recipes as a hook, lets see how will this go.

Also updated the flake.

commit 7c6f324

test(justrecipe): Include build command dependency for test recipe.

The recipe runs some tests that require florestad to be built before running so it makes sense to using the build recipe as a command dependency.

@jaoleal
Copy link
Collaborator Author

jaoleal commented Feb 9, 2026

tested locally.

Can i ack my own pr ?

@luisschwab
Copy link
Member

You're the only Nix user here, so I guess 🤷‍♂️.

Did you use any tool to lint the justfile?

@jaoleal
Copy link
Collaborator Author

jaoleal commented Feb 10, 2026

I normally use justs own fmt method.

I applied some linting on #676 but it got staled

@jaoleal
Copy link
Collaborator Author

jaoleal commented Feb 10, 2026

You're the only Nix user here, so I guess 🤷‍♂️.

@Davidson-Souza Are there any ways for me to have write permission for the flake.nix and flake.lock ?

.pre-commit-config.yaml

# direnv cache
.direnv/
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

direnv is pretty useful and a lot of people use it but its normal for it to leave some hidden files, just being sure for it to not be commited.

@Davidson-Souza
Copy link
Member

You're the only Nix user here, so I guess 🤷‍♂️.

@Davidson-Souza Are there any ways for me to have write permission for the flake.nix and flake.lock ?

No. Git doesn't see files at that level

@Davidson-Souza Davidson-Souza added the nix This change relates to the nix integration for floresta label Feb 10, 2026
@luisschwab
Copy link
Member

LGTM if my review above is addressed

The recipe runs some tests that require florestad to be built before running so it makes sense to using the build recipe as a command dependency.
The previous setup of pre-commit used rusts version from them, this often caused version bugs and instead of fixing that I took the approach of running our just recipes as a hook, lets see how will this go.

Also updated the flake.
@jaoleal
Copy link
Collaborator Author

jaoleal commented Feb 10, 2026

075d79b every test recipe runs the build recipe as a dependency

Copy link
Member

@luisschwab luisschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 075d79b

Copy link
Member

@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 075d79b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nix This change relates to the nix integration for floresta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants