-
Notifications
You must be signed in to change notification settings - Fork 84
Flake: use just recipes as hooks, update flake. Just: include build recipe as a dependency for test recipe. #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
tested locally. Can i ack my own pr ? |
|
You're the only Nix user here, so I guess 🤷♂️. Did you use any tool to lint the |
|
I normally use justs own fmt method. I applied some linting on #676 but it got staled |
@Davidson-Souza Are there any ways for me to have write permission for the |
| .pre-commit-config.yaml | ||
|
|
||
| # direnv cache | ||
| .direnv/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
direnv is pretty useful and a lot of people use it but its normal for it to leave some hidden files, just being sure for it to not be commited.
No. Git doesn't see files at that level |
|
LGTM if my review above is addressed |
The recipe runs some tests that require florestad to be built before running so it makes sense to using the build recipe as a command dependency.
The previous setup of pre-commit used rusts version from them, this often caused version bugs and instead of fixing that I took the approach of running our just recipes as a hook, lets see how will this go. Also updated the flake.
d10a898 to
075d79b
Compare
|
075d79b every test recipe runs the build recipe as a dependency |
luisschwab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 075d79b
Davidson-Souza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 075d79b
Description and Notes
commit d10a898
commit 7c6f324