Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing some of the clunkiness with setting DataStores #49

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

mpekurny
Copy link
Contributor

No description provided.

Signed-off-by: Pekurny, Martin <mpekurny@paychex.com>
@mpekurny
Copy link
Contributor Author

I don't understand why the build checks aren't running?

Signed-off-by: Pekurny, Martin <mpekurny@paychex.com>
@sriv
Copy link
Member

sriv commented Nov 27, 2024

build checks are good now. I see that there is a breaking change in the IClassInstanceManager - this will require a tandem change in the runner. Which would in-turn require a min Lib version to be raised in all the test projects that use gauge-java.

I like the change, but I just wanted to make sure we are all aware of the transitive nature of this change.

@mpekurny
Copy link
Contributor Author

Yes, I have the runner changes ready to go. I just wanted nuget to get updated so I can pull down the "officially" built package for the integration test projects.

@mpekurny
Copy link
Contributor Author

If you would prefer, I could push up the runner with my locally built lib and we can merge the runner first.

@gaugebot
Copy link

gaugebot bot commented Nov 27, 2024

@mpekurny Thank you for contributing to gauge-csharp-lib. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@sriv sriv merged commit d1c596e into getgauge:master Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants