Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize gauge typescript plugin #170

Merged
merged 65 commits into from
Jun 11, 2024
Merged

Conversation

zabil
Copy link
Member

@zabil zabil commented Jun 4, 2024

  • Update remove old unmaintained packages
  • Add new linter and formatter
  • Upgrade to typescript 5
  • Use npx to launch ts-node in the runner
  • Use grpc client for testing instead of mocking
  • Use npm workspaces to add and run functional tests

@zabil zabil closed this Jun 4, 2024
@BugDiver BugDiver reopened this Jun 6, 2024
@zabil zabil marked this pull request as draft June 6, 2024 15:00
zabil added 27 commits June 10, 2024 10:25
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
zabil added 16 commits June 10, 2024 13:07
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
This service does not have a website and is unmaintained

Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
@zabil zabil marked this pull request as ready for review June 11, 2024 10:16
Copy link
Member Author

@zabil zabil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BugDiver appreciate it if you can take a quick look at this PR. It uses npm workspaces now to add better testing. I've modified the token in the settings to publish to gauge -ts. So hopefully this should publish on merge. 🤞

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing eslint and migrating to https://biomejs.dev as it's faster and supports formatting too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over here the major changes are upgrading to node 20 as well as splitting the jobs into running unit test of gauge-ts and an e2e test which runs a sample gauge spec that refers to the gauge-ts package. This way it can check if changes affect gauge specs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove some old badges and change bugdiver to getgauge. Hope that's ok.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new npm workspace project for running e2e tests. It refers to gauge-ts but runs gauge specs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big changes here. The new protobuf implementation prevents describing anything other that rpc methods so we can't add custom fields. So you can see processors stored as static fields instead.

@zabil
Copy link
Member Author

zabil commented Jun 11, 2024

@BugDiver Also how does release work? I don't see a release candidate label.

@BugDiver
Copy link
Member

@BugDiver Also how does release work? I don't see a release candidate label.

The release was not automated for this repo, I always published it manually.
There is an release Action which perform the release, but trigger mechanism for that action was manual.
I have forgotten how we automated the release for other repos 🥺, let me jog my memory,
I 'll update the release mechanism.

@BugDiver
Copy link
Member

Here is the script which is used to trigger the release action
https://github.com/getgauge/gauge-ts/blob/main/release.sh

@zabil
Copy link
Member Author

zabil commented Jun 11, 2024

I 'll update the release mechanism.

Ah ok, that'll be great!

@BugDiver
Copy link
Member

I guess the ReleaseCandidate (defined at org level) is not showing up for this repo, because if was transferred, and not created.

@BugDiver BugDiver added the ReleaseCandidate If a PR is tagged with this label, after merging it will be released label Jun 11, 2024
@gaugebot
Copy link

gaugebot bot commented Jun 11, 2024

@zabil Thank you for contributing to gauge-ts. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@BugDiver BugDiver merged commit 9f417b9 into getgauge:main Jun 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReleaseCandidate If a PR is tagged with this label, after merging it will be released
Development

Successfully merging this pull request may close these issues.

2 participants