Update click.js for relative selectors #2747
Conversation
|
Do I need to re-submit for the DCO? Edit: I think I figured it out. Let me know if i need to do anything else |
If a Relative Selector is passed in as the third argument inside of click(), it doesn't actually make it down to waitAndGetActionableElement. We found that `await click(element, options, within(withinElement))` doesn't search in the "within" element Signed-off-by: DCoomer <deshuncoomer@gmail.com>
|
@DCoomer Thank you for contributing to taiko. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
| @@ -49,11 +49,11 @@ async function simulateInputEvents(options) { | |||
| } | |||
|
|
|||
| async function click(selector, options = {}, ...args) { | |||
There was a problem hiding this comment.
Can we please add a unit test for this case ?
taiko/test/unit-tests/click.test.js
Line 149 in 6645c6d
|
Thanks for the PR :) |
Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com>
Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com>
|
Updated the formatting 617b982 |
|
Looks like it is still failing for format |
Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com>
|
Updated Again |
Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com>
|
Added the proper HTML for the unit test |
* Update click.js for relative selectors If a Relative Selector is passed in as the third argument inside of click(), it doesn't actually make it down to waitAndGetActionableElement. We found that `await click(element, options, within(withinElement))` doesn't search in the "within" element Signed-off-by: DCoomer <deshuncoomer@gmail.com> * Updated Unit Test for #2747 Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com> * Updated Unit Test Formatting for #2747 Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com> * Updated Unit Test Formatting for #2747 Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com> * Updated Unit Test HTML and formatting for #2747 Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com> * Bump Version for 2747 Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com> * Bump Version for 2747 Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com> --------- Signed-off-by: DCoomer <deshuncoomer@gmail.com> Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com>
If a Relative Selector is passed in as the third argument inside of click(), it doesn't actually make it down to waitAndGetActionableElement.
We found that
await click(element, options, within(withinElement))doesn't search in the "within" element with the Biome Migration changesSigned-off-by: DCoomer deshuncoomer@gmail.com