Don't mock channel opening on lnurlw initiation #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-21
approved these changes
Dec 23, 2024
gcomte
force-pushed
the
mock/dont-open-channel-on-collect-offer-initiation
branch
from
1fd8edf to
dd33deb
Compare
andrei-21
approved these changes
Dec 23, 2024
gcomte
deleted the
mock/dont-open-channel-on-collect-offer-initiation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an LNURL-withdraw process is started, there is no Lightning payment taking place just yet, so we should not already simulate a channel opening.
The channel opening will be simulated later on, when the actual payment takes place.