Implement `prepare_refund_failed_swap()` #712

danielgranhao · 2023-10-24T11:45:02Z

No description provided.

src/lib.rs

dleutenegger · 2023-11-13T08:24:19Z

src/lipalightninglib.udl

@@ -85,6 +85,9 @@ interface LightningNode {
    [Throws=LnError]
    sequence<FailedSwapInfo> get_unresolved_failed_swaps();

+    [Throws=LnError]
+    FailedSwapRefundInfo prepare_refund_failed_swap(FailedSwapInfo failed_swap_info, string to_address, u32 onchain_fee_rate);


Might make sense to expand the FailedSwapRefundInfo to be used as an argument in the resolve_failed_swap method.

I think we don't need to force the use of the prepare method. Why do we need more info other than the swap address?

I was just thinking from the client perspective, but I might have misunderstood the use of the prepare_refund_failed_swap method.

As a client if, and here I'm not sure if that's the case, I always call the prepare_refund_failed_swap method before refunding a swap would prefer to just supply the response from this to the refund_failed_swap method.
But if the client doesn't always call the prepare method before, this doesn't make sense.

Sure. It definitely wasn't strictly needed that the prepare method is used, but we expect it to always be used, so let's do it like you propose. Implemented in 784bea6

src/lipalightninglib.udl

Co-authored-by: Dominic <dominic@getlipa.com>

danielgranhao force-pushed the feature/prepare-failed-swap-refund branch from 6ce5633 to 89d313b Compare October 24, 2023 11:46

danielgranhao changed the title ~~Feature/prepare failed swap refund~~ Implement prepare_refund_failed_swap() Oct 24, 2023

danielgranhao force-pushed the feature/resolve-failed-swaps branch 2 times, most recently from e266e70 to 8743455 Compare October 25, 2023 15:40

Base automatically changed from feature/resolve-failed-swaps to main-breez October 25, 2023 16:08

danielgranhao changed the base branch from main-breez to main October 26, 2023 11:12

danielgranhao closed this Nov 10, 2023

danielgranhao force-pushed the feature/prepare-failed-swap-refund branch from 89d313b to 504b4d4 Compare November 10, 2023 16:27

danielgranhao reopened this Nov 10, 2023

danielgranhao force-pushed the feature/prepare-failed-swap-refund branch from c547c56 to fe6ca62 Compare November 10, 2023 16:31

danielgranhao marked this pull request as ready for review November 10, 2023 16:33

dleutenegger requested changes Nov 13, 2023

View reviewed changes

danielgranhao requested a review from dleutenegger November 13, 2023 16:10

danielgranhao added 2 commits November 13, 2023 16:14

Implement prepare_refund_failed_swap()

9f17da3

Improve names and docs

42952a4

danielgranhao force-pushed the feature/prepare-failed-swap-refund branch from b7788fc to 42952a4 Compare November 13, 2023 16:15

dleutenegger reviewed Nov 14, 2023

View reviewed changes

src/lipalightninglib.udl Outdated Show resolved Hide resolved

danielgranhao and others added 2 commits November 14, 2023 13:32

Remove empty line

07ab943

Co-authored-by: Dominic <dominic@getlipa.com>

Use ResolveFailedSwapInfo as only param to resolve_failed_swap

784bea6

dleutenegger approved these changes Nov 14, 2023

View reviewed changes

danielgranhao merged commit 67abe26 into main Nov 14, 2023
13 checks passed

danielgranhao deleted the feature/prepare-failed-swap-refund branch November 14, 2023 14:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement `prepare_refund_failed_swap()` #712

Implement `prepare_refund_failed_swap()` #712

danielgranhao commented Oct 24, 2023 •

edited

Loading

dleutenegger Nov 13, 2023

danielgranhao Nov 13, 2023

dleutenegger Nov 14, 2023

danielgranhao Nov 14, 2023 •

edited

Loading

Implement prepare_refund_failed_swap() #712

Implement prepare_refund_failed_swap() #712

Conversation

danielgranhao commented Oct 24, 2023 • edited Loading

dleutenegger Nov 13, 2023

Choose a reason for hiding this comment

danielgranhao Nov 13, 2023

Choose a reason for hiding this comment

dleutenegger Nov 14, 2023

Choose a reason for hiding this comment

danielgranhao Nov 14, 2023 • edited Loading

Choose a reason for hiding this comment

Implement `prepare_refund_failed_swap()` #712

Implement `prepare_refund_failed_swap()` #712

danielgranhao commented Oct 24, 2023 •

edited

Loading

danielgranhao Nov 14, 2023 •

edited

Loading