Reverse payment list in example CLI app #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-21
reviewed
Oct 30, 2023
examples/3l-node/cli.rs
Outdated
| @@ -845,7 +845,7 @@ fn list_payments(node: &LightningNode) -> Result<(), String> { | |||
| }; | |||
|
|
|||
| println!("Total of {} payments\n", payments.len().to_string().bold()); | |||
| for payment in payments { | |||
| for payment in payments.iter().rev() { | |||
There was a problem hiding this comment.
If you do into_iter() then probably you do not need other changes:
Suggested change
| for payment in payments.iter().rev() { | |
| for payment in payments.into_iter().rev() { |
There was a problem hiding this comment.
Right 🤦 thanks!
danielgranhao
force-pushed
the
feature/reverse-payment-list-in-example-app
branch
from
d94bba2 to
681695c
Compare
andrei-21
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the latest payment appears in the bottom, making it much easier to follow.