Add error codes to topup #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dleutenegger
force-pushed
the
feature/provide-topup-error-codes
branch
2 times, most recently
from
d19ac9f to
754ddee
Compare
dleutenegger
force-pushed
the
feature/provide-topup-error-codes
branch
from
754ddee to
70c76e4
Compare
andrei-21
reviewed
Oct 13, 2023
crow/src/lib.rs
Outdated
| }) | ||
| } | ||
|
|
||
| pub fn from_topup_error(error: Option<TopupError>) -> Option<String> { |
There was a problem hiding this comment.
Please remove it if we do not use it here.
The reason is that imagine we will change the string representations here, but the client is using it to store information in a db, they will not be able to read old records. It is the client responsibility to find a stable way to represent enum values as string.
andrei-21
reviewed
Oct 13, 2023
crow/src/lib.rs
Outdated
Comment on lines
255
to
257
| _ => TopupError::TemporaryFailure { | ||
| code: TemporaryFailureCode::Unexpected, | ||
| }, |
There was a problem hiding this comment.
Suggested change
| _ => TopupError::TemporaryFailure { | |
| code: TemporaryFailureCode::Unexpected, | |
| }, | |
| e => TopupError::PermanentFailure { | |
| code: PermanentFailureCode::Unexpected { msg: e.to_string() }, | |
| }, |
Co-authored-by: Daniel Granhão <32176319+danielgranhao@users.noreply.github.com>
andrei-21
approved these changes
Oct 13, 2023
dleutenegger
force-pushed
the
feature/provide-topup-error-codes
branch
from
ef8f180 to
672c429
Compare
danielgranhao
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.