Fix chdir leaking on error out of cd-contextmanager of tests/helper.py. #3720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
While working on something else, I happened to spot a bug in
tests/helper.py
: The change of directory can (unintentionally) leak out of thecd
context manager if the code inside the context throws an exception. In other words, on error, the change of directory is not undone.I added a test for the test helper that demonstrates the bug if run with the previous test helper code. Not sure whether you want that.
This is a rather trivial change not visible to the end-user, so there is no need to add to CHANGELOG.
I plead guilty not having created a separate bug issue first. Do you need it in such a trivial case?