[#6439] Fix UI of repeat labels #6459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karntrehan
commented
Oct 16, 2024
| @@ -117,6 +117,7 @@ | |||
| <string name="add_repeat">Add</string> | |||
| <string name="dont_add_repeat">Do not add</string> | |||
| <string name="add_another_menu">Add another</string> | |||
| <string name="add_another_question">Add another?</string> | |||
There was a problem hiding this comment.
Not sure how translations are done. Did not see it in the readme also. Kindly advice.
|
Tried to look at the style guide mentioned here Line 44 in e828193 |
|
The UI looks good to me. I wait for the others to chime in on implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6439
Why is this the best possible solution? Were any other approaches considered?
Is a simple change. No approaches considered.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No regressions. Tests have been added. Need translations though.
Do we need any specific form for testing your changes? If so, please attach one.
Added in the code.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Not applicable
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still pass - Some are failing here without my changes as wellDateFormatsTest- NA