Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submission as submit event payload #289

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brontolosone
Copy link
Contributor

@brontolosone brontolosone commented Jan 22, 2025

Towards #23
Towards #290

Requirement of getodk/central-frontend#1125

With this, the submission becomes available to a "host application" as in the payload of the Vue event that is emitted when the submit button is used.

I have verified this PR works in these browsers (latest versions):

  • Chrome
  • Firefox
  • Safari (macOS)
  • Safari (iOS)
  • Not applicable

What else has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

Instead of having to await in the event handler, we could instead await right here in Webforms-land so that the event handling code doesn't have to. Perhaps that's easier for host application writers. I'm happy with it either way.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Do we need any specific form for testing your changes? If so, please attach one.

What's changed

Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: a5c90e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant